pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email )
Change subject: sccp_scoc.c: assert value of sua_addr_parse() ......................................................................
sccp_scoc.c: assert value of sua_addr_parse()
Related: Coverity CID#523214 Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec --- M src/sccp_scoc.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/40298/1
diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 4e390af..fa373af 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -917,7 +917,7 @@ if (xua) { udisp->cause = xua_msg_get_u32(xua, SUA_IEI_CAUSE); if (xua_msg_find_tag(xua, SUA_IEI_SRC_ADDR)) - sua_addr_parse(&udisp->responding_addr, xua, SUA_IEI_SRC_ADDR); + OSMO_ASSERT(sua_addr_parse(&udisp->responding_addr, xua, SUA_IEI_SRC_ADDR) == 0); data_ie = xua_msg_find_tag(xua, SUA_IEI_DATA); udisp->importance = xua_msg_get_u32(xua, SUA_IEI_IMPORTANCE); if (data_ie) { @@ -1035,8 +1035,8 @@ case SCOC_E_RCOC_CONN_IND: xua = data; /* copy relevant parameters from xua to conn */ - sua_addr_parse(&conn->calling_addr, xua, SUA_IEI_SRC_ADDR); - sua_addr_parse(&conn->called_addr, xua, SUA_IEI_DEST_ADDR); + OSMO_ASSERT(sua_addr_parse(&conn->calling_addr, xua, SUA_IEI_SRC_ADDR) == 0); + OSMO_ASSERT(sua_addr_parse(&conn->called_addr, xua, SUA_IEI_DEST_ADDR) == 0); conn->remote_ref = xua_msg_get_u32(xua, SUA_IEI_SRC_REF); conn->sccp_class = xua_msg_get_u32(xua, SUA_IEI_PROTO_CLASS) & 3; conn->importance = xua_msg_get_u32(xua, SUA_IEI_IMPORTANCE);
-
pespin