Attention is currently required from: laforge, pespin, daniel. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 )
Change subject: Introduce libsmpputil ......................................................................
Patch Set 12:
(4 comments)
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/81de3b94_3767e669 PS2, Line 32: $(top_srcdir)/src/libmsc/smpp_smsc.h \
i think it would be cleaner, yes. […]
Done
File tests/db_sms/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/902ded69_9247060b PS11, Line 40: $(top_builddir)/src/libsmpputil/libsmpputil.a \
You now only build libsmpputil if BUILD_SMPP, but db_sms_test is built unconditionally. […]
It's odd that this wasn't caught by Jenkins. Thanks!
File tests/msc_vlr/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/0d2d4c85_34161b27 PS11, Line 35: $(top_builddir)/src/libsmpputil/libsmpputil.a \
Same
Done
File tests/sms_queue/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/09521b50_6cf4e67f PS11, Line 39: $(top_builddir)/src/libsmpputil/libsmpputil.a \
Same
Done
-
msuraev