Attention is currently required from: dexter, neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email )

Change subject: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0 ......................................................................

Patch Set 3:

(6 comments)

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/af2b6608_db3feb0d PS3, Line 1317: ip

missing msgb_free()? […]

Ack to the missing msgb_free.

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/46e8821d_54b68d11 PS3, Line 1323: urn -

maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP?

I'm not following you here. The flag is set by the caller and used here, it makes no sense to unset it in this code.

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/093ca3fd_392fe499 PS3, Line 1339: et

same as above, maybe just skip this when port == 0

I prefer the way it is now. The caller controls what it wants to send through the presence flags, and if the user wants to sent a port, it's clear that port 0 is wrong.

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/90f97406_0c117396 PS3, Line 1353: codecs

this conflicts with branch neels/fmtp […]

Whichever gets first into master makes the other one rebase it, I don't really care and it's fine each way. In any case, I'm fixing customer direct problems here, so it makes no sense delaying this commit imho.

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/1c78306b_82a52e21 PS3, Line 1367: *

indent

Ack

https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/5f670cee_be93eb67 PS3, Line 1373: *

.

Ack