Attention is currently required from: dexter, neels.
6 comments:
File src/libosmo-mgcp-client/mgcp_client.c:
missing msgb_free()? […]
Ack to the missing msgb_free.
Patch Set #3, Line 1323: urn -
maybe we should just omit the address, same as unset flag _PRESENCE_AUDIO_IP?
I'm not following you here. The flag is set by the caller and used here, it makes no sense to unset it in this code.
same as above, maybe just skip this when port == 0
I prefer the way it is now. The caller controls what it wants to send through the presence flags, and if the user wants to sent a port, it's clear that port 0 is wrong.
Patch Set #3, Line 1353: codecs
this conflicts with branch neels/fmtp […]
Whichever gets first into master makes the other one rebase it, I don't really care and it's fine each way.
In any case, I'm fixing customer direct problems here, so it makes no sense delaying this commit imho.
indent
Ack
.
Ack
To view, visit change 35152. To unsubscribe, or for help writing mail filters, visit settings.