Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 )
Change subject: layer23: Introduce APN VTY node ......................................................................
Patch Set 3:
(3 comments)
File src/host/layer23/include/osmocom/bb/common/apn.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/658b8428_5835d2b0 PS3, Line 49: shut-down
this spelling looks weird, "shutdown" or "shut down"? https://en.wikipedia.org/wiki/Shutdown […]
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/02ee4398_4aca2cdb PS3, Line 51: sequeence
sequence
Ack
File src/host/layer23/src/common/apn.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/88cbdce7_fd738219 PS3, Line 47: {
should it remove itself from ms->gprs.apn_list here? […]
It's doing exactly that in the line below (48).
-
pespin