Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hlr/+/33096 )
Change subject: Introduce support for XOR-2G algorithm
......................................................................
Patch Set 3:
(1 comment)
File src/hlr_vty_subscr.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/33096/comment/3817790e_9d75f621
PS3, Line 665: SUBSCR_UPDATE "aud3g xor-3g k K"
you are breaking old configs here. You may want to add
a deprecated entry linking to this new one.
this is not a configuration command, but
one from the ENABLE node. So I'm breaking "only" the user interface, but
not any old configs.
Given that I doubt there ever were many users of XOR, and it's just one step to look
into the vty reference manual (or even just tab completion) to find the new command, I
think we are fine here.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/33096
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I039a1f84fda54a908a82fe621e7fd078cb85e4c6
Gerrit-Change-Number: 33096
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 May 2023 09:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment