Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 4: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5cca2146_5d94189b PS4, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/67d5c7f1_3cb79a58 PS4, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/764ca7aa_d2ab1bd9 PS4, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d130cc4b_135ebc9b PS4, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a9b2b1ea_84aa9c38 PS4, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/26a88708_e0c397b0 PS4, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9b09ea95_a9da3a03 PS4, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/73d097a0_622d2625 PS4, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/3881047a_d51ec8b0 PS4, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e1c51d64_cfcc4c28 PS4, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fabb92a8_094086cd PS4, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9b59ca45_b4558bf9 PS4, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7870de6d_171ecfa9 PS4, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5a603b79_85756af8 PS4, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/cc09c3d1_db9dceff PS4, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ac51e92_d0eb828d PS4, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/cca37578_1016c849 PS4, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/21b86069_f2f13e18 PS4, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/579cef39_3f2027bf PS4, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/42dbc390_3df65347 PS4, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/607eb07d_91e2a74d PS4, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ebf02f71_30e7a96d PS4, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ba91663b_8b4dda98 PS4, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1fbf600b_cce22efc PS4, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/27518212_fef839c0 PS4, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c749fd0b_0300d07d PS4, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/38822558_8243730b PS4, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f6e53b95_e121921f PS4, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/49441006_af136fea PS4, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5854aaf7_c632957c PS4, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d1d0cc55_53c5808e PS4, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/88493a8c_2cd643a1 PS4, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/70c22b00_faab758f PS4, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/ef48b395_df13c315 PS4, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/643cbb64_8e272c36 PS4, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1324a83a_5dc4df39 PS4, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/91bc8e6a_5c9f50a9 PS4, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2b0f29cf_9e38708d PS4, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f1d202df_e8c57257 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/6e600438_8a470da6 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/06a242fe_22ada977 PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2810): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/86014121_8b1e74aa PS4, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 4 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 17 Jan 2023 15:28:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment