Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 ) Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ...................................................................... Patch Set 8: Code-Review-1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/0a902a05_748ed3ee PS8, Line 10: "direct TLLI" method, the TLLI (and the paging group) is premended to this needs updating. We are sending the IMSI now. Does "premended" really exist btw? first time I hear it. File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/ad37ce51_5dbb5f63 PS8, Line 579: pch_dt->tlli, pch_dt->imsi, pag_grp); wrong indentation https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/f78b599b_980d8050 PS8, Line 581: msg = msgb_alloc(sizeof(pch_dt->data), "pcu_pch"); why creating a new msg and copying the contents? Can you simply remove the header from the existing one? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6acbd243adf26169e5e8319dd66bb68dd6a3c22 Gerrit-Change-Number: 31578 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Mar 2023 17:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment