Attention is currently required from: fixeria, dexter.

Patch set 8:Code-Review -1

View Change

3 comments:

• Commit Message:

  • Patch Set #8, Line 10: "direct TLLI" method, the TLLI (and the paging group) is premended to

    this needs updating. We are sending the IMSI now.
    Does "premended" really exist btw? first time I hear it.

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #8, Line 579: pch_dt->tlli, pch_dt->imsi, pag_grp);

    wrong indentation

  • Patch Set #8, Line 581: msg = msgb_alloc(sizeof(pch_dt->data), "pcu_pch");

    why creating a new msg and copying the contents? Can you simply remove the header from the existing one?

To view, visit change 31578. To unsubscribe, or for help writing mail filters, visit settings.