Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email ) Change subject: [TEST] contrib/generate_build_dep.sh: manually install meck ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: This looks like the right approach, given that rebar3 can't fetch the test deps. File contrib/generate_build_dep.sh: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787/comment/8b583a76_9f2d… : PS2, Line 20: git clone https://github.com/eproxus/meck _checkouts/meck I suggest using --depth 1, and download a specific tag so it doesn't fail unexpectedly if there should be breaking changes in master: ``` git clone --depth 1 --branch 0.9.2 https://github.com/eproxus/meck _checkouts/meck ``` Furthermore I suggest setting the same version in rebar.config, and adding a comment to rebar.config that if the version gets modified there, it must also be adjusted in generate_build_dep.sh. Also I would move it before the "delete erlang bytecode" line. There doesn't seem to be any in the git repository, but then it's directly obvious that we don't use bytecode from there. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id36eab57cf4dce723c8bbf2554c35fe85b6e2378 Gerrit-Change-Number: 37787 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Aug 2024 08:25:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No