Attention is currently required from: fixeria.

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    This looks like the right approach, given that rebar3 can't fetch the test deps.

• File contrib/generate_build_dep.sh:

  • Patch Set #2, Line 20: git clone https://github.com/eproxus/meck _checkouts/meck

    I suggest using --depth 1, and download a specific tag so it doesn't fail unexpectedly if there should be breaking changes in master:

    ```
    git clone --depth 1 --branch 0.9.2 https://github.com/eproxus/meck _checkouts/meck
    ```

    Furthermore I suggest setting the same version in rebar.config, and adding a comment to rebar.config that if the version gets modified there, it must also be adjusted in generate_build_dep.sh.

    Also I would move it before the "delete erlang bytecode" line. There doesn't seem to be any in the git repository, but then it's directly obvious that we don't use bytecode from there.

To view, visit change 37787. To unsubscribe, or for help writing mail filters, visit settings.