Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39714?usp=email )

Change subject: mgw: Early reject CRCX with X-Osmux if disabled by config ......................................................................

Patch Set 1:

(1 comment)

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39714/comment/0d31d946_cdf86984?usp=... : PS1, Line 898: rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX));

unexpected for me that the counter gets increased here, with this description: […]

Yeah I even see it being used differently in line 984, the actual meaning of this counter is basically broken and needs to be fixed, but that's something probably left for a follow-up patch, and I'd rather do this once I finish untangling all this code :)