Attention is currently required from: laforge, tnt.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email )

Change subject: Add new protocol command and events for Sa bits and line states ......................................................................

Patch Set 2:

(2 comments)

File include/osmocom/e1d/proto.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/0db4c6c8_0679e6d7 PS1, Line 83: E1DP_EVT_SABITS = 0x7f,

any specific reason to go with 0x7f rather than the next free +1, i.e. […]

If new line events are added in the future, I don't want to have Sa-bits event between line events.

File src/proto.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/d74259ac_3abdb1ce PS1, Line 44: { E1DP_CMD_SABITS, "E1DP_CMD_SABITS" },

Remove E1DP_ prefix for consistency

Done