Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 ) Change subject: osmo_io: Avoid potential double free when sending msgb ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/9ecd61d6_911ec2b4 PS1, Line 16: mean time. To avoid that set the parent of any msgb in the tx queue to the Just wait until you're my age.. Patchset: PS1: I'm also not 100% happy with it. All msgbs should be owned by the iofd except for the msgbs passed to the read callback. I'll change the code that iofd is the default parent of new msgbs and only talloc_steal() the msgbs before they are passed to the read_cb. I think that both simplifies things and makes the intent clear. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/22b931a0_67927036 PS1, Line 324: Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94 Gerrit-Change-Number: 34144 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Aug 2023 14:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment