Attention is currently required from: neels.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052?usp=email )

Change subject: msc: split off f_mo_call_establish__handle_assignment_request() ......................................................................

Patch Set 2:

(3 comments)

File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/f2ba93a0_1dafc... PS2, Line 1557: f_mo_call_establish__handle_assignment_request Hmm, I find the double low-dash a bit weird, but guessing you did it intentionally?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/d0db350a_0c788... PS2, Line 1573: not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, tla_ass1 btw, this matching statement can be simplified a bit to:

``` if (not match(ass_req.pdu.bssmap.assignmentRequest.aoIPTransportLayer, (tla_ass1, tla_ass2)) ```

not strictly related to this patch, just an idea

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35052/comment/75febbd8_3e1d3... PS2, Line 1690: valueof(ts_CodecFR Hmm, so now you're explicitly passing `ts_CodecFR`, but the new function may overwrite it to `ts_CodecCSData`. I find this confusing. Passing the right codec template here _conditionally_ would be cleaner, IMO:

``` if (cpars.csd) { f_mo_call_establish__handle_assignment_request(cpars, bssap, valueof(ts_CodecCSData)); } else { f_mo_call_establish__handle_assignment_request(cpars, bssap, valueof(ts_CodecFR)); } ```