Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 2: (57 comments) File Transceiver52M/device/bladerf/bladerf.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/02758b33_3ec9d528 PS2, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/570b87e8_38196db0 PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/91011ee4_c30b98a0 PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/09de9f83_c4f8205e PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/730481f2_fc42c4ed PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/948c4825_d9543cbb PS2, Line 61: int open(const std::string &args, int ref, bool swap_channels); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c4aec15c_e418a07c PS2, Line 62: bool start(); Bad function definition - bool start() should probably be bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c9994346_110097dd PS2, Line 63: bool stop(); Bad function definition - bool stop() should probably be bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/92b1c31b_09b776fb PS2, Line 64: bool restart(); Bad function definition - bool restart() should probably be bool restart(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/365dc44c_ff36e14e PS2, Line 65: enum TxWindowType getWindowType() Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/82c17625_c4aefe04 PS2, Line 65: enum TxWindowType getWindowType() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6ae539ec_d802a982 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b43b20f4_8c2159d3 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/f5fe67fb_61f667c1 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/35c5ac04_bbfe16a1 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/dca826b1_bcdad5b0 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b4b013fa_ee6a6977 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/76a7739e_3c2a7ec6 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); function definition argument 'short *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/83479c1b_52849f40 PS2, Line 79: TIMESTAMP initialWriteTimestamp(); Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/059feb11_73612ef3 PS2, Line 80: TIMESTAMP initialReadTimestamp(); Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/73c834a7_ce03f917 PS2, Line 82: double fullScaleInputValue(); Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c5416cf5_188db17e PS2, Line 83: double fullScaleOutputValue(); Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/56bbd38d_dee844b3 PS2, Line 87: double maxRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/30b3a93d_09cea634 PS2, Line 91: double minRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c326538f_bf8dc6fd PS2, Line 104: double getRxFreq(); Bad function definition - double getRxFreq() should probably be double getRxFreq(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d0eba465_e01ead07 PS2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/78c5e56e_da57aea2 PS2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/18cf4bc8_96d6dfb6 PS2, Line 110: std::string getRxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/39bf4831_4c638f9d PS2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8c69f395_c764fe88 PS2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/2af965db_3573f1e5 PS2, Line 118: std::string getTxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ce00226f_2a66c5d6 PS2, Line 123: bool requiresRadioAlign(); Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/64fad0d2_ee6858a2 PS2, Line 125: GSM::Time minLatency(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/94dd65fb_1df681ae PS2, Line 127: inline double getSampleRate() Bad function definition - double getSampleRate() should probably be double getSampleRate(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6e23a67b_4d031d4a PS2, Line 135: bool recv_async_msg(); Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a157531a_84b71590 PS2, Line 144: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3d924f0a_20d291d9 PS2, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/aa06279f_45c7fe60 PS2, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5ce8f427_6ae9e494 PS2, Line 155: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8b86ad03_25bdf820 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a335ddb6_be0aed72 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e1f1d98b_f7a8fb50 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ac5a8082_1c6ae147 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3c52f881_b1f956a5 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e08cb8b8_0e9c6189 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/afa4c1e6_d73c4b4c PS2, Line 169: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/63f48f26_531de063 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/96fdeaf0_432ace4d PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3ee04ce3_3500d8a7 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d469be2c_43f28e35 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b448a38e_07ba6ed0 PS2, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7d64db75_28444d4b PS2, Line 174: std::vector<short *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/584261a6_83ed9e3d PS2, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7973fcea_02e25b9b PS2, Line 174: std::vector<short *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a7564172_0b158a38 PS2, Line 176: void init_gains(); Bad function definition - void init_gains() should probably be void init_gains(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b2ec9065_953fc2dc PS2, Line 178: void set_rates(); Bad function definition - void set_rates() should probably be void set_rates(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7f13033e_79b8ca05 PS2, Line 182: void get_dev_band_desc(dev_band_desc &desc); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 14:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment