Attention is currently required from: pespin.
57 comments:
File Transceiver52M/device/bladerf/bladerf.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 61: int open(const std::string &args, int ref, bool swap_channels);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 62: bool start();
Bad function definition - bool start() should probably be bool start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 63: bool stop();
Bad function definition - bool stop() should probably be bool stop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 64: bool restart();
Bad function definition - bool restart() should probably be bool restart(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 65: enum TxWindowType getWindowType()
Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 65: enum TxWindowType getWindowType()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
function definition argument 'short *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 79: TIMESTAMP initialWriteTimestamp();
Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 80: TIMESTAMP initialReadTimestamp();
Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 82: double fullScaleInputValue();
Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 83: double fullScaleOutputValue();
Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 87: double maxRxGain(void)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 91: double minRxGain(void)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 104: double getRxFreq();
Bad function definition - double getRxFreq() should probably be double getRxFreq(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 110: std::string getRxAntenna(size_t chan)
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 118: std::string getTxAntenna(size_t chan)
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 123: bool requiresRadioAlign();
Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 125: GSM::Time minLatency();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 127: inline double getSampleRate()
Bad function definition - double getSampleRate() should probably be double getSampleRate(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 135: bool recv_async_msg();
Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 144: protected:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 155: std::vector<double> tx_gains, rx_gains;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 155: std::vector<double> tx_gains, rx_gains;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 155: std::vector<double> tx_gains, rx_gains;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 156: std::vector<double> tx_freqs, rx_freqs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 156: std::vector<double> tx_freqs, rx_freqs;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 156: std::vector<double> tx_freqs, rx_freqs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 169: std::vector<smpl_buf *> rx_buffers;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 169: std::vector<smpl_buf *> rx_buffers;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 169: std::vector<smpl_buf *> rx_buffers;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 169: std::vector<smpl_buf *> rx_buffers;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 171: std::vector<std::vector<short> > pkt_bufs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 174: std::vector<short *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 174: std::vector<short *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 174: std::vector<short *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 174: std::vector<short *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 176: void init_gains();
Bad function definition - void init_gains() should probably be void init_gains(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 178: void set_rates();
Bad function definition - void set_rates() should probably be void set_rates(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516):
Patch Set #2, Line 182: void get_dev_band_desc(dev_band_desc &desc);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
To view, visit change 30413. To unsubscribe, or for help writing mail filters, visit settings.