Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31496 ) Change subject: utils: use built-in static_assert() if available ...................................................................... Patch Set 1: (3 comments) File include/osmocom/core/utils.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3976): https://gerrit.osmocom.org/c/libosmocore/+/31496/comment/6abd79f2_349a09ac PS1, Line 88: #define osmo_static_assert(exp, name) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3976): https://gerrit.osmocom.org/c/libosmocore/+/31496/comment/865b4847_d2b24a07 PS1, Line 89: typedef int dummy##name [(exp) ? 1 : -1] __attribute__((__unused__)); do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3976): https://gerrit.osmocom.org/c/libosmocore/+/31496/comment/577f7fcd_1faf421e PS1, Line 89: typedef int dummy##name [(exp) ? 1 : -1] __attribute__((__unused__)); space prohibited before open square bracket '[' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5ca34bc14c05e8c38c721d7df33feb1c6c41c76e Gerrit-Change-Number: 31496 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 24 Feb 2023 12:10:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment