Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email )

Change subject: sccp_scoc.c: assert value of sua_addr_parse() ......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1:

also, we have 13 instances of invoking sua_addr_parse without checking the return value, by far the […]

If you "git pull origin master" you will see I already handled all of them (most with return paths isntad of asserts) except this 3 in this patch which I somehow oversaw at the time.

PS1:

should we assert if the SCCP user hands us incorrect data? I would hope we're not venturing into op […]

No, this 3 asserts I'm adding AFAIU are in paths where we control the data being used, it's not the rx path when receiving from a peer, but us generating the messages or addr comming from conn object.