[XS] Change in libosmo-sigtran[master]: sccp_scoc.c: assert value of sua_addr_parse() - gerrit-log

15 May 2025

Attention is currently required from: laforge.

pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email )

Change subject: sccp_scoc.c: assert value of sua_addr_parse()
......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1: 
...
  also, we have 13 instances of invoking sua_addr_parse
without checking the return value, by far the  […] If you "git pull origin
master" you will see I already handled all of them (most with return paths isntad of
asserts) except this 3 in this patch which I somehow oversaw at the time.

PS1: 
...
  should we assert if the SCCP user hands us incorrect
data?  I would hope we're not venturing into op […] No, this 3 asserts I'm
adding AFAIU are in paths where we control the data being used, it's not the rx path
when receiving from a peer, but us generating the messages or addr comming from conn
object.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40298?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I008ee6f9024247c14d986a2baba061cc12bf68ec
Gerrit-Change-Number: 40298
Gerrit-PatchSet: 1
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Thu, 15 May 2025 12:48:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;