Attention is currently required from: pespin, dexter.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 )

Change subject: PCUIF_Types: add record PCUIF_pch_dt ......................................................................

Patch Set 2: Code-Review-1

(2 comments)

File library/PCUIF_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/c93d7381_98d11... PS1, Line 320: octetstring data length(162)

But a mac block is 23 bytes -> 184 bits?

162 is not bits here, it's actually bytes. One MAC block in GSM (since we're talking about PCH) is 23 bytes long, so it should be `data length(23)`. I just checked `pcuif_proto.h`, and I see `uint8_t data[GSM_MACBLOCK_LEN]` in `struct gsm_pcu_if_pch_dt`.

File library/PCUIF_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/a28e163f_f6668... PS2, Line 319: octetstring Can we use `charstring` here? It would have been more convenient.