Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email )
Change subject: Release BSS connection when CC transaction fails ......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/838efbfb_8321fa0f?usp=... : PS1, Line 2640: return -EINVAL;
shall we do something here?
For the record, we found out that this check is no-op because `gsm48_hdr_msg_type()` returns `hdr->msg_type & 0x3f` for `GSM48_PDISC_CC`. It's always false because `msg_type` has bits 6-7 zeroed. See: https://gerrit.osmocom.org/c/osmo-msc/+/38579.
https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/3f2652bb_c62836dd?usp=... : PS1, Line 2645: return -EINVAL;
shall we do something here?
We concluded that `MSC_A_USE_CM_SERVICE_CC` should be put here too.
-
fixeria