Attention is currently required from: jolly, pespin.

View Change

2 comments:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #1, Line 2640: return -EINVAL;

    shall we do something here?

    For the record, we found out that this check is no-op because `gsm48_hdr_msg_type()` returns `hdr->msg_type & 0x3f` for `GSM48_PDISC_CC`. It's always false because `msg_type` has bits 6-7 zeroed. See: https://gerrit.osmocom.org/c/osmo-msc/+/38579.

  • Patch Set #1, Line 2645: return -EINVAL;

    shall we do something here?

    We concluded that `MSC_A_USE_CM_SERVICE_CC` should be put here too.

To view, visit change 38513. To unsubscribe, or for help writing mail filters, visit settings.