Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 3: (19 comments) File src/host/layer23/include/osmocom/bb/common/tun.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/186701e3_8a456785 PS3, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c62a0c6d_737469cf PS3, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/d92ec039_b2546736 PS3, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4835e660_f99633a2 PS3, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, Unnecessary space before function pointer arguments File src/host/layer23/src/common/tun.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/f5d44f86_94630fbf PS3, Line 48: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/a8e19fd2_19a640d1 PS3, Line 53: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0da1b314_1459d283 PS3, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/12a88a52_d82b0726 PS3, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/216ed1ad_9e2fd847 PS3, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/ef0587fc_c6d561f4 PS3, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/217b5821_9e841e79 PS3, Line 214: strcpy(ifr.ifr_name, dev_name); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/cdd70534_b0cee370 PS3, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/79bb078a_22f33c72 PS3, Line 229: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/520347f7_3cb0e7aa PS3, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/90b7a13e_349e1b5c PS3, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/8c16f3e5_63f76ac8 PS3, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0efda56f_07a98928 PS3, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/5dbacae1_add26fe1 PS3, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2794): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/80fdb36b_62f93e27 PS3, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 12:39:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment