[S] Change in osmo-pcu[master]: gprs_rlcmac_sched: rewrite logic around idle block skip - gerrit-log

6 Dec 2023


      Attention is currently required from: dexter, fixeria, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email )
Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip
......................................................................
Patch Set 2:
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/62be0ca9_4b9b1c36 
PS1, Line 486: 			 * way we help BTS energy saving (on TRX!=C0) by sending nothing
...
Oops, sending an empty (idle) PDCH block causes osmo-bts-sysmo to crash. This is a bug in l1_if. […]
On the other hand: Because osmo-pcu does not send empty PDCH blocks to sysmo-bts (and other models), a fix is actually not required. Current PCU decides wether to generate dummy block or idle block, not the osmo-bts code.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6
Gerrit-Change-Number: 35151
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: jolly andreas@eversberg.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 06 Dec 2023 10:23:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment