Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32988 ) Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue ...................................................................... Patch Set 1: (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/f0de429a_646eb8d4 PS1, Line 1237: default: I am not removing the logic of suppressing AMR bwe, I simply moved it to the rtp_payload_input_preen() function that executes before enqueueing, rather than after dequeueing. File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/d978b405_9b5eee00 PS1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case Yes, as well as an extended FR/EFR format of my own invention (falconia/rtp_traulike branch) which I will be addressing much later, certainly after discussing it in OsmoDevCall, not before. I did not know this detail! It was certainly one of those "how am I supposed to know this arcane detail" moments... The header octet stripping logic is never needed for AMR - so if you say that Osmux is AMR only, then I need to rethink and redesign this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7fc99aeecba8303b56d397b8952de5eea82b301e Gerrit-Change-Number: 32988 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 May 2023 09:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment