Attention is currently required from: falconia.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32988 )

Change subject: refactor: replace rtppayload_is_valid() with preening before enqueue ......................................................................

Patch Set 1:

(3 comments)

Patchset:

PS1: Ass discussed, this patch needs to be reworked based on osmux being AMR-only.

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/d6d0d549_867cbbb9 PS1, Line 1237: default:

I am not removing the logic of suppressing AMR bwe, I simply moved it to the rtp_payload_input_preen […]

Ack

File src/common/osmux.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32988/comment/eb35ee5d_f41e0d9e PS1, Line 413: /* We have to apply the same checks as in l1sap_rtp_rx_cb(), in case

...

I understood this extra byte was only appearing in HR? […]

yes, it's AMR only. In case you want to know more on the topic: https://ftp.osmocom.org/docs/osmo-bsc/master/osmux-reference.pdf