Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 )
Change subject: Added BSC tests for terminating voice group calls
......................................................................
Patch Set 2:
(7 comments)
File bsc/BSC_Tests_ASCI.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/6ecf2314_2e57…
PS1, Line 38: const charstring VGCS_CALL_EST := "VGCS_CALL_EST";
what about prefixing them with COORD_ or
VGCS_COORD_MSG to quicjlt understand those are coordination […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/dd2c29f8_6a07…
PS1, Line 98: var boolean uplink_free := false;
I have the feeling you actually want to have some sort
of enum containing states, and then update th […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/9856303a_10fd…
PS1, Line 106: if (true) { /* VGCS/VBS ASS REQ in SCCP CR */
sounds like this needs fixing ;)
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/0ca076fe_39e7…
PS1, Line 187: [] T.timeout {
iiuc the timeout happens at the end, so you can move
all this code block after the alt?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/346040e8_8c9d…
PS1, Line 382: f_sleep(2.0);
why is this needed? it shouldn't?
If I
don't sleep here, the test will start before the BSC has completed startup and is
ready for SCCP connections. Without that sleep the test will fail if this is the first
test that is executed.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/6a04a8a9_6475…
PS1, Line 494: f_sleep(1.0);
check all this sleeps, I don't see a need for
them?
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/d0b5a91e_fa83…
PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD);
smells like race condition if this connect takes to
much and some of them already sent a message.
the functions handlers will wait one
second after starting. I hope this prevents the race condition.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6762e8adfb7d5f77df837c698ff70cd7fd715ffe
Gerrit-Change-Number: 33150
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Jun 2023 10:05:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment