Attention is currently required from: pespin.

View Change

7 comments:

• File bsc/BSC_Tests_ASCI.ttcn:

  • Patch Set #1, Line 38: const charstring VGCS_CALL_EST := "VGCS_CALL_EST";

    what about prefixing them with COORD_ or VGCS_COORD_MSG to quicjlt understand those are coordination […]

    Done

  • Patch Set #1, Line 98: var boolean uplink_free := false;

    I have the feeling you actually want to have some sort of enum containing states, and then update th […]

    Done

  • Patch Set #1, Line 106: if (true) { /* VGCS/VBS ASS REQ in SCCP CR */

    sounds like this needs fixing ;)

    Done

  • Patch Set #1, Line 187: [] T.timeout {

    iiuc the timeout happens at the end, so you can move all this code block after the alt?

    Done

  • Patch Set #1, Line 382: f_sleep(2.0);

    why is this needed? it shouldn't?

    If I don't sleep here, the test will start before the BSC has completed startup and is ready for SCCP connections. Without that sleep the test will fail if this is the first test that is executed.

  • Patch Set #1, Line 494: f_sleep(1.0);

    check all this sleeps, I don't see a need for them?

    Done

  • Patch Set #1, Line 507: connect(call_conn:COORD, chan_conn:COORD);

    smells like race condition if this connect takes to much and some of them already sent a message.

    the functions handlers will wait one second after starting. I hope this prevents the race condition.

To view, visit change 33150. To unsubscribe, or for help writing mail filters, visit settings.