Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email ) Change subject: library/PCUIF_Types: clean up, drop remains of PCUIFv10 ...................................................................... Patch Set 3: (2 comments) File library/PCUIF_CodecPort.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372/comment/186953a0_e5e5… PS3, Line 41: if (ischosen(pout.data.u.data_cnf)) { fix_padding(pout.data.u.data_cnf); } Nope, because `data_cnf2` contains no data, but only a message ID. File library/PCUIF_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372/comment/6bd32d23_9b41… PS3, Line 51: /* RFU, removed in PCUIFv11 ('02'O), */ Reserved for Future Use. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibfe8558cb9f335d8c29348063b0ff02b138dd4c7 Gerrit-Change-Number: 35372 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Dec 2023 13:14:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment