Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email ) Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/tch_voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/3185fe5b_1c32aed2 PS1, Line 135: #endif is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. Maybe you want to move it before the break? otherwise I'd suggest adding an: #else /* fall through */ #endif -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment