Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30717 ) Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... Patch Set 1: (74 comments) File include/osmocom/trau/trau_pcu_ericsson.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/18c730f8_0464f4be PS1, Line 126: /* Modulation to be applied on coresponding uplink frame, also used to retrive 'retrive' may be misspelled - perhaps 'retrieve'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/81ef6685_4e346dfa PS1, Line 157: /* Data integrety checks (uplink only) */ 'integrety' may be misspelled - perhaps 'integrity'? File src/trau/trau_pcu_ericsson.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/fa3f9404_a504921a PS1, Line 319: osmo_pbit2ubit_ext(buf, 0, (ubit_t *) & value, 32 - len, len, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/5760dbfb_adb5aff2 PS1, Line 386: osmo_ubit2pbit_ext((pbit_t *) & result, 32 - len, buf, 0, len, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/3b5a2743_74a7ab02 PS1, Line 502: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *) & ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/695d1f12_d45c86e1 PS1, Line 557: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *) & ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/02c1b94a_ab1a0a8b PS1, Line 573: /* NOTE: The 16K TRAU frames do not have enough bandwith to 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/f5f94c74_e5f8abaf PS1, Line 602: osmo_pbit2ubit_ext(trau_bits, 30, (pbit_t *) & ind->timing_offset, 0, 8, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/4252600f_519219ed PS1, Line 605: osmo_pbit2ubit_ext(trau_bits, 38, (pbit_t *) & ind->atten_db, 4, 4, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/7a130f60_cf26370e PS1, Line 621: /* NOTE: The 16K TRAU frames do not have enough bandwith to 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/487edc6c_2435174a PS1, Line 707: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 22, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/5e5829ab_09eae919 PS1, Line 767: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 22, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/3b6b3e4e_15de98d2 PS1, Line 780: osmo_ubit2pbit_ext((pbit_t *) & e_2_4, 5, trau_bits, 26, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/8eea59ff_83f514d4 PS1, Line 793: * due to bandwith limitations. */ 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/49f8d8a3_da0292f4 PS1, Line 799: osmo_ubit2pbit_ext((pbit_t *) & sfq, 5, trau_bits, 29, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/feea7724_d32a6ea5 PS1, Line 806: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 33, 6, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/db0f07ab_41d96ffc PS1, Line 809: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 39, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/5e66f4ec_22a48fbf PS1, Line 819: ind->est_acc_del_dev = +1; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/45d4f567_3d89127f PS1, Line 822: ind->est_acc_del_dev = +2; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d5397e4f_0f572f9d PS1, Line 826: ind->est_acc_del_dev = +3; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/243deba3_4bc81e73 PS1, Line 842: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 45, 184, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ede7021e_af46fd8d PS1, Line 851: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 45, 271, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/f5ea6c1b_aa729dca PS1, Line 857: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 48, 256, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/fb606385_2fad5bfb PS1, Line 893: osmo_ubit2pbit_ext((pbit_t *) & c_1_5, 0, bits, 17, 5, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/df1bb3b3_3f9322d1 PS1, Line 1064: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/52269e3f_d807bcf2 PS1, Line 1136: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/3f376371_1a77ba76 PS1, Line 1215: osmo_pbit2ubit_ext(trau_bits, 80, (pbit_t *) & ind->timing_offset, 0, 8, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/f4e78066_ae180c4e PS1, Line 1218: osmo_pbit2ubit_ext(trau_bits, 106, (pbit_t *) & ind->atten_db, 4, 4, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/b98113e0_0d8ae8b6 PS1, Line 1270: /* NOTE: The 16K TRAU frames do not have enough bandwith to 'bandwith' may be misspelled - perhaps 'bandwidth'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/83454931_d79d8da4 PS1, Line 1322: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/700292ce_87da32e4 PS1, Line 1361: osmo_pbit2ubit_ext(trau_bits, 79, (pbit_t *) & ind->atten_db, 4, 4, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/28e33975_5a188c2a PS1, Line 1490: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/236938fa_73081e38 PS1, Line 1567: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/611cd480_bb6a5de0 PS1, Line 1580: osmo_ubit2pbit_ext((pbit_t *) & e_2_4, 5, trau_bits, 74, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/0dc55ef8_c2907505 PS1, Line 1612: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 77, 6, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/8e7f0854_e6fe2be6 PS1, Line 1615: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 83, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/81e755aa_d2acce15 PS1, Line 1625: ind->est_acc_del_dev = +1; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/a6fc3eef_20ed344a PS1, Line 1628: ind->est_acc_del_dev = +2; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/96c5c942_99179c7b PS1, Line 1632: ind->est_acc_del_dev = +3; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/a267049a_79a60c05 PS1, Line 1648: osmo_ubit2pbit_ext((pbit_t *) & sfq, 5, trau_bits, 86, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/68668c73_fab8cd0a PS1, Line 1656: osmo_ubit2pbit_ext((pbit_t *) & mean_bep, 1, trau_bits, 86, 7, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/b5e7a24b_41403e64 PS1, Line 1660: osmo_ubit2pbit_ext((pbit_t *) & cv_bep, 5, trau_bits, 93, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/f035c553_8b670f3b PS1, Line 1684: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 184, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/420d7bfc_8b5ef6b1 PS1, Line 1693: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 271, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/a528c351_be77d22c PS1, Line 1697: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 315, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/4c38e9de_6113b2ee PS1, Line 1701: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 431, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/1b0b8aae_4950f3f0 PS1, Line 1707: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 40, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d4263736_e1a27baf PS1, Line 1726: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 209, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/687b0699_b0428481 PS1, Line 1730: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 257, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d6da5930_8c5201a6 PS1, Line 1734: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 329, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/292a8ab9_8ab8d90a PS1, Line 1738: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 385, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ce67db26_fba719ca PS1, Line 1742: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 487, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d09f8e3d_6864313f PS1, Line 1746: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 631, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/4b798891_3a1d8dae PS1, Line 1750: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 946, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/766b2a8c_1c7d3c78 PS1, Line 1754: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 1138, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/eecc7c4a_d656ca88 PS1, Line 1765: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 144, 256, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/97ee8ab4_7028b93a PS1, Line 1826: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/4aa4e2f8_27b2047e PS1, Line 1842: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 74, 6, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/0a6ebd66_c096257b PS1, Line 1845: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 80, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/77f69055_c9f8be6e PS1, Line 1855: ind->est_acc_del_dev = +1; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/e6130c52_8c2a26da PS1, Line 1858: ind->est_acc_del_dev = +2; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/0aa4859d_1499e86d PS1, Line 1862: ind->est_acc_del_dev = +3; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/4147e61b_c4c17ed1 PS1, Line 1876: osmo_ubit2pbit_ext((pbit_t *) & mean_bep, 1, trau_bits, 83, 7, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/2734760f_237bb027 PS1, Line 1880: osmo_ubit2pbit_ext((pbit_t *) & cv_bep, 5, trau_bits, 90, 3, 0); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ef60adda_372fbfd5 PS1, Line 1921: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, block, 0, sizeof(block), 1); space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/5d5a0a78_ceb72266 PS1, Line 1954: osmo_ubit2pbit_ext((pbit_t *) & c_1_5, 0, bits, 65, 5, 1); space prohibited after that '&' (ctx:WxW) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/e39e506b_d6d0885a PS1, Line 373: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/23889bad_12afc5e9 PS1, Line 387: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/8c3a2088_47fe083e PS1, Line 401: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/9eed3a1c_c1f8d008 PS1, Line 1248: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/78abdc9a_6efd21d6 PS1, Line 1307: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/666eb0ed_64e95714 PS1, Line 1319: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d573a37f_2a8ea724 PS1, Line 1333: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ec795cd0_ab41c81f PS1, Line 1347: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 20 Dec 2022 12:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment