74 comments:
File include/osmocom/trau/trau_pcu_ericsson.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 126: /* Modulation to be applied on coresponding uplink frame, also used to retrive
'retrive' may be misspelled - perhaps 'retrieve'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 157: /* Data integrety checks (uplink only) */
'integrety' may be misspelled - perhaps 'integrity'?
File src/trau/trau_pcu_ericsson.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 319: osmo_pbit2ubit_ext(buf, 0, (ubit_t *) & value, 32 - len, len, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 386: osmo_ubit2pbit_ext((pbit_t *) & result, 32 - len, buf, 0, len, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 502: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *) & ind->tav, 0, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 557: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *) & ind->tav, 0, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 573: /* NOTE: The 16K TRAU frames do not have enough bandwith to
'bandwith' may be misspelled - perhaps 'bandwidth'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 602: osmo_pbit2ubit_ext(trau_bits, 30, (pbit_t *) & ind->timing_offset, 0, 8, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 605: osmo_pbit2ubit_ext(trau_bits, 38, (pbit_t *) & ind->atten_db, 4, 4, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 621: /* NOTE: The 16K TRAU frames do not have enough bandwith to
'bandwith' may be misspelled - perhaps 'bandwidth'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 707: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 22, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 767: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 22, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 780: osmo_ubit2pbit_ext((pbit_t *) & e_2_4, 5, trau_bits, 26, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 793: * due to bandwith limitations. */
'bandwith' may be misspelled - perhaps 'bandwidth'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 799: osmo_ubit2pbit_ext((pbit_t *) & sfq, 5, trau_bits, 29, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 806: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 33, 6, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 809: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 39, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 819: ind->est_acc_del_dev = +1;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 822: ind->est_acc_del_dev = +2;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 826: ind->est_acc_del_dev = +3;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 842: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 45, 184, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 851: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 45, 271, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 857: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 48, 256, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 893: osmo_ubit2pbit_ext((pbit_t *) & c_1_5, 0, bits, 17, 5, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1064: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1136: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1215: osmo_pbit2ubit_ext(trau_bits, 80, (pbit_t *) & ind->timing_offset, 0, 8, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1218: osmo_pbit2ubit_ext(trau_bits, 106, (pbit_t *) & ind->atten_db, 4, 4, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1270: /* NOTE: The 16K TRAU frames do not have enough bandwith to
'bandwith' may be misspelled - perhaps 'bandwidth'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1322: osmo_pbit2ubit_ext(trau_bits, 70, (pbit_t *) & ind->tav, 0, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1361: osmo_pbit2ubit_ext(trau_bits, 79, (pbit_t *) & ind->atten_db, 4, 4, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1490: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1567: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1580: osmo_ubit2pbit_ext((pbit_t *) & e_2_4, 5, trau_bits, 74, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1612: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 77, 6, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1615: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 83, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1625: ind->est_acc_del_dev = +1;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1628: ind->est_acc_del_dev = +2;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1632: ind->est_acc_del_dev = +3;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1648: osmo_ubit2pbit_ext((pbit_t *) & sfq, 5, trau_bits, 86, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1656: osmo_ubit2pbit_ext((pbit_t *) & mean_bep, 1, trau_bits, 86, 7, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1660: osmo_ubit2pbit_ext((pbit_t *) & cv_bep, 5, trau_bits, 93, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1684: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 184, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1693: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 271, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1697: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 315, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1701: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 431, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1707: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 40, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1726: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 209, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1730: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 257, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1734: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 329, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1738: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 385, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1742: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 487, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1746: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 631, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1750: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 946, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1754: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 134, 1138, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1765: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, trau_bits, 144, 256, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1826: osmo_ubit2pbit_ext((pbit_t *) & ind->tav, 0, trau_bits, 70, 2, 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1842: osmo_ubit2pbit_ext((pbit_t *) & ind->rx_lev, 2, trau_bits, 74, 6, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1845: osmo_ubit2pbit_ext((pbit_t *) & eadd, 5, trau_bits, 80, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1855: ind->est_acc_del_dev = +1;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1858: ind->est_acc_del_dev = +2;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1862: ind->est_acc_del_dev = +3;
need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1876: osmo_ubit2pbit_ext((pbit_t *) & mean_bep, 1, trau_bits, 83, 7, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1880: osmo_ubit2pbit_ext((pbit_t *) & cv_bep, 5, trau_bits, 90, 3, 0);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1921: osmo_ubit2pbit_ext((pbit_t *) & ind->data, 0, block, 0, sizeof(block), 1);
space prohibited after that '&' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1954: osmo_ubit2pbit_ext((pbit_t *) & c_1_5, 0, bits, 65, 5, 1);
space prohibited after that '&' (ctx:WxW)
File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 373: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 387: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 401: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1248: /* [...] shortened since decode wont access filler bits after
'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1307: /* [...] shortened since decode wont access filler bits after
'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1319: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1333: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2117):
Patch Set #1, Line 1347: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev);
Use %d instead of %i
To view, visit change 30717. To unsubscribe, or for help writing mail filters, visit settings.