Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760?usp=email )
Change subject: clean up slot reset hack
......................................................................
Patch Set 1:
(1 comment)
File ccid_common/ccid_slot_fsm.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760/comment/0336dbc0_81…
:
PS1, Line 108: void extern_fsm_reset_hack(struct ccid_slot *cs)
so this removes the entire method that was added in the previous patch? Wouldn't it
make sense to squash it then? Or if there is a reason to do it in two steps, a single
line explaining the rationale in the commit log would be useful.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Iebde945661569882d136406b8c11fa9653323d37
Gerrit-Change-Number: 39760
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Mar 2025 17:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No