Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29965 )

Change subject: Split gsn_t related APIs out of gtp.{c,h} ......................................................................

Patch Set 1:

(60 comments)

File gtp/gsn.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ca62fffb_3b2df9d5 PS1, Line 68: int (*cb_delete_context) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fec525bc_04c24584 PS1, Line 68: int (*cb_delete_context) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e044636d_f94e5f92 PS1, Line 69: int (*cb_create_context_ind) (struct pdp_t *); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2f364709_9898bbf6 PS1, Line 69: int (*cb_create_context_ind) (struct pdp_t *); function definition argument 'struct pdp_t *' should also have an identifier name

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1d8ed5bd_72022206 PS1, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1b89f1a3_f095d0a9 PS1, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/48ba3d27_6de8472b PS1, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/703dafe8_e1ee1366 PS1, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/033a447e_f072e729 PS1, Line 72: int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/e1b517f4_3c7efe06 PS1, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/06decc05_1fcafcf0 PS1, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/deaa4a48_757cdce5 PS1, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/ef0fae62_28654cf2 PS1, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/69a7d6a2_339503c9 PS1, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f9a9e572_eb242796 PS1, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/259a415f_4472675e PS1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/21a5f86b_7f6afc98 PS1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/bb0de93d_95b2f41b PS1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7e6fba5a_c2140f5d PS1, Line 77: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/81f6082f_3abcc4bc PS1, Line 120: int (*cb_create_context_ind) (struct Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1cbe40ef_53b06dbc PS1, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fc315f9b_ecaa2219 PS1, Line 124: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/c54d4cf9_b09fefd8 PS1, Line 127: int (*cb_delete_context) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/877a3b59_abbda2b6 PS1, Line 133: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/94dd2f90_d1c52fe3 PS1, Line 133: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b5a30fea_35f6192a PS1, Line 136: int (*cb) (struct sockaddr_in * peer)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/a41fdd99_654a2bec PS1, Line 136: int (*cb) (struct sockaddr_in * peer)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/447ceffe_e94a3b9a PS1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/24f871ff_b614bc13 PS1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)); Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/376bd46c_77d81502 PS1, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4ba7f32c_6b19c2f1 PS1, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/1c3e39e1_6bdc10c4 PS1, Line 146: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/0909d460_4472facc PS1, Line 146: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/66426df2_bf1ceccc PS1, Line 150: int (*cb) (struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/52ef2bc6_bd7545b9 PS1, Line 150: int (*cb) (struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/3167fdb8_fc5d1805 PS1, Line 151: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/2c8da3ae_9d07d665 PS1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7227a80c_c65c7bdf PS1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/d7189419_36fa09d7 PS1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/fbda3acf_518df305 PS1, Line 156: struct pdp_t * pdp, "foo * bar" should be "foo *bar"

File gtp/gsn.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/88d76f1c_47e5a91c PS1, Line 70: #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \ macros should not use a trailing semicolon

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/b7454b9a_f6a2e4b1 PS1, Line 125: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/9bc38c4b_624bf52d PS1, Line 125: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/128e585a_5a932d44 PS1, Line 132: int (*cb) (struct sockaddr_in * peer)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/8172b708_9880cb19 PS1, Line 132: int (*cb) (struct sockaddr_in * peer)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/5586560d_cb645a2d PS1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/0f02e7b5_0c8c2318 PS1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/da2ded6d_ce601866 PS1, Line 147: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/16b4d642_db0c5f1a PS1, Line 154: int (*cb) (int type, int cause, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/aa766398_67a46e57 PS1, Line 155: struct pdp_t * pdp, void *cbp)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/194ec7b3_794e1f37 PS1, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/61e0b524_a4a914ea PS1, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/727e3a55_e55c1c9b PS1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7d2a768c_054c602a PS1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/dd05b90f_b1926e38 PS1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery)) Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/f36ee845_a88a67e4 PS1, Line 190: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/711291f9_a09a0046 PS1, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, "foo * bar" should be "foo *bar"

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/7f326b32_07e0e133 PS1, Line 198: int (*cb_data_ind) (struct pdp_t * pdp, Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/4cc2dbc7_0e787f66 PS1, Line 517: int (*cb_create_context_ind) (struct pdp_t * Unnecessary space before function pointer arguments

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670): https://gerrit.osmocom.org/c/osmo-ggsn/+/29965/comment/59217b8b_1edba6a0 PS1, Line 536: } adding a line without newline at end of file