60 comments:
File gtp/gsn.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 68: int (*cb_delete_context) (struct pdp_t *);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 68: int (*cb_delete_context) (struct pdp_t *);
function definition argument 'struct pdp_t *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 69: int (*cb_create_context_ind) (struct pdp_t *);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 69: int (*cb_create_context_ind) (struct pdp_t *);
function definition argument 'struct pdp_t *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 70: int (*cb_unsup_ind) (struct sockaddr_in * peer);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 71: int (*cb_extheader_ind) (struct sockaddr_in * peer);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 72: int (*cb_ran_info_relay_ind) (struct sockaddr_in *peer, union gtpie_member **ie);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 73: int (*cb_conf) (int type, int cause, struct pdp_t * pdp, void *cbp);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 74: int (*cb_data_ind) (struct pdp_t * pdp, void *pack, unsigned len);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 75: int (*cb_recovery) (struct sockaddr_in * peer, uint8_t recovery);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 76: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 77: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer, struct pdp_t *pdp, uint8_t recovery);
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 120: int (*cb_create_context_ind) (struct
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 124: int (*cb_data_ind) (struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 124: int (*cb_data_ind) (struct pdp_t * pdp,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 127: int (*cb_delete_context) (struct pdp_t *
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 133: int (*cb) (struct sockaddr_in * peer));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 133: int (*cb) (struct sockaddr_in * peer));
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 136: int (*cb) (struct sockaddr_in * peer));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 136: int (*cb) (struct sockaddr_in * peer));
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie));
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie));
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 142: int (*cb) (int type, int cause, struct pdp_t * pdp,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 146: int (*cb) (struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 146: int (*cb) (struct sockaddr_in * peer,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 150: int (*cb) (struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 150: int (*cb) (struct sockaddr_in * peer,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 151: struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 155: int (*cb) (struct gsn_t * gsn, struct sockaddr_in * peer,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 156: struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
File gtp/gsn.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 70: #define LOGP_WITH_ADDR(ss, level, addr, fmt, args...) \
macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 125: int (*cb) (struct sockaddr_in * peer))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 125: int (*cb) (struct sockaddr_in * peer))
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 132: int (*cb) (struct sockaddr_in * peer))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 132: int (*cb) (struct sockaddr_in * peer))
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 139: int (*cb) (struct sockaddr_in * peer, union gtpie_member **ie))
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 147: int gtp_set_cb_delete_context(struct gsn_t *gsn, int (*cb) (struct pdp_t * pdp))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 154: int (*cb) (int type, int cause,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 155: struct pdp_t * pdp, void *cbp))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 162: int (*cb) (struct sockaddr_in * peer, uint8_t recovery))
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery))
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 176: int (*cb_recovery2) (struct sockaddr_in * peer, struct pdp_t * pdp, uint8_t recovery))
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 190: int (*cb_recovery3) (struct gsn_t *gsn, struct sockaddr_in *peer,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 198: int (*cb_data_ind) (struct pdp_t * pdp,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 198: int (*cb_data_ind) (struct pdp_t * pdp,
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
Patch Set #1, Line 517: int (*cb_create_context_ind) (struct pdp_t *
Unnecessary space before function pointer arguments
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-670):
adding a line without newline at end of file
To view, visit change 29965. To unsubscribe, or for help writing mail filters, visit settings.