Attention is currently required from: pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32194 )

Change subject: nm: Apply BTS/TRX/TS OML Attributes through NM FSMs ......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/common/nm_bb_transc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32194/comment/b492c938_85289805 PS2, Line 132: (struct abis_om_fom_hdr *)msgb_l3(setattr_data->msg))->msg_type can we not afford a local variable? IMHO it's really unusual to typ-cast a poinetr to msgb_l3 and dereference it to pass as argument.