Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 1: Code-Review-1 (10 comments) Patchset: PS1: Few small things to clean up, otherwise good. File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a41e15f3_d229b0e7 PS1, Line 51: fprintf(stderr, "%s:%s:%d %s\n", __FILE__, __FUNCTION__, __LINE__, bladerf_strerror(status)); \ LOGP? https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ae39cbd3_dc96c1cd PS1, Line 240: ts_offset = 60; //static_cast<TIMESTAMP>(desc.offset * rx_rate); maybe add some TODO/FIXME comment about this? https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8f9ea403_7a982311 PS1, Line 422: // Create receive buffer use comment style: /* */ https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0d9e8324_13d8a4da PS1, Line 427: // Create vector buffer use comment style: /* */ https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/f4eadbb4_36ab525f PS1, Line 432: // Initialize and shadow gain values use comment style: /* */ https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/54b3a7f1_8a827c2b PS1, Line 466: // Start streaming use comment style: /* */ Check all the file below for same type of issues. https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/26354d52_2909b7d4 PS1, Line 701: relatively recent machines shows that the B100 will underrun when B100? is this a BladeRF? https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/71228494_9e196583 PS1, Line 727: #ifndef IPCMAGIC what's this for? File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/28c1f574_ab1bcdf3 PS1, Line 346: Transceiver52M/device/ipc2/Makefile \ ipc2? this is probably not related to this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Thu, 01 Dec 2022 12:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment