Attention is currently required from: Hoernchen.
Patch set 1:Code-Review -1
10 comments:
Patchset:
Few small things to clean up, otherwise good.
File Transceiver52M/device/bladerf/bladerf.cpp:
Patch Set #1, Line 51: fprintf(stderr, "%s:%s:%d %s\n", __FILE__, __FUNCTION__, __LINE__, bladerf_strerror(status)); \
LOGP?
Patch Set #1, Line 240: ts_offset = 60; //static_cast<TIMESTAMP>(desc.offset * rx_rate);
maybe add some TODO/FIXME comment about this?
Patch Set #1, Line 422: // Create receive buffer
use comment style: /* */
Patch Set #1, Line 427: // Create vector buffer
use comment style: /* */
Patch Set #1, Line 432: // Initialize and shadow gain values
use comment style: /* */
Patch Set #1, Line 466: // Start streaming
use comment style: /* */
Check all the file below for same type of issues.
Patch Set #1, Line 701: relatively recent machines shows that the B100 will underrun when
B100? is this a BladeRF?
Patch Set #1, Line 727: #ifndef IPCMAGIC
what's this for?
File configure.ac:
Patch Set #1, Line 346: Transceiver52M/device/ipc2/Makefile \
ipc2? this is probably not related to this patch.
To view, visit change 30413. To unsubscribe, or for help writing mail filters, visit settings.