Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 ) Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE ...................................................................... Patch Set 1: Code-Review+1 (4 comments) File src/gb_proxy_vty.c: https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/dba53766_6faa1d2d PS1, Line 549: if (!strcmp(argv[0], "bss")) { you could simply store g_cfg->bss_nses or g_cfg->sgsn_nses in a pointer and use shared code below. https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/f51e1b09_b0cfd9ac PS1, Line 550: hash_for_each(g_cfg->bss_nses, i, nse, list) please add {} around hash_for_each https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/663ccfa6_f829ac7e PS1, Line 554: hash_for_each(g_cfg->sgsn_nses, i, nse, list) please add {} around hash_for_each https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/52c9319d_1e5bc1ab PS1, Line 588: hash_for_each(g_cfg->cells, i, cell, list) please add {} around hash_for_each -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12 Gerrit-Change-Number: 29714 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Oct 2022 14:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment