Attention is currently required from: daniel.

Patch set 1:Code-Review +1

View Change

4 comments:

• File src/gb_proxy_vty.c:

  • Patch Set #1, Line 549: if (!strcmp(argv[0], "bss")) {

    you could simply store g_cfg->bss_nses or g_cfg->sgsn_nses in a pointer and use shared code below.

  • Patch Set #1, Line 550: hash_for_each(g_cfg->bss_nses, i, nse, list)

    please add {} around hash_for_each

  • Patch Set #1, Line 554: hash_for_each(g_cfg->sgsn_nses, i, nse, list)

    please add {} around hash_for_each

  • Patch Set #1, Line 588: hash_for_each(g_cfg->cells, i, cell, list)

    please add {} around hash_for_each

To view, visit change 29714. To unsubscribe, or for help writing mail filters, visit settings.