Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 ) Change subject: RLCMAC_CSN1_Types: Add release 6 additions to PacketCellChangeNotification ...................................................................... Patch Set 1: (3 comments) File library/RLCMAC_CSN1_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/330ac55e_0e70… PS1, Line 166: utran_target_cell_presence := omit, the PRESENCE is used during decoding, not during encoding afaik. I guess this allows generating incorrect messages on purpose for testing purposes? File library/RLCMAC_CSN1_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/616d850c_9d2d… PS1, Line 1016: BIT1 ba_psi3_presence, Add a /* TODO: Rel-8 addition */ here https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995/comment/5d537756_897e… PS1, Line 1030: variant (utran_target_cell) "PRESENCE(arfcn_bsic_presence = '1'B, utran_target_cell_presence = '0'B)" I think it may make sense to have the ARFCN+BSIC CSN.1 struct as a record here, it would simplify a bit this imho. Also, you may want to have a look at TAG, it may be clearer here, since in here it's not really about optional fields, but about taking one or another substruct. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e1c63c06fb89111765df187a93db563e77c3fc4 Gerrit-Change-Number: 32995 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 May 2023 13:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment