Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130 )
Change subject: cnpool: make NRI mappings VTY configurable ......................................................................
Patch Set 1:
(6 comments)
File src/osmo-hnbgw/hnbgw_vty.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/d7a5cf79_b5dec2f7 PS1, Line 357: #define NRI_ARGS_TO_STR_ARGS(ARGC, ARGV) ARGV[0], (ARGC>1)? ".." : "", (ARGC>1)? ARGV[1] : "" spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/112bce24_6df75d80 PS1, Line 357: #define NRI_ARGS_TO_STR_ARGS(ARGC, ARGV) ARGV[0], (ARGC>1)? ".." : "", (ARGC>1)? ARGV[1] : "" spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/5c6cd2eb_4a6f9cd9 PS1, Line 357: #define NRI_ARGS_TO_STR_ARGS(ARGC, ARGV) ARGV[0], (ARGC>1)? ".." : "", (ARGC>1)? ARGV[1] : "" spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/9811da44_2752ca42 PS1, Line 357: #define NRI_ARGS_TO_STR_ARGS(ARGC, ARGV) ARGV[0], (ARGC>1)? ".." : "", (ARGC>1)? ARGV[1] : "" spaces required around that '?' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/86fa6295_23be62a4 PS1, Line 518: if (message) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7702): https://gerrit.osmocom.org/c/osmo-hnbgw/+/33130/comment/235f054c_728cc61b PS1, Line 558: if (message) { braces {} are not necessary for single statement blocks
-
Jenkins Builder