Attention is currently required from: neels, laforge, daniel, lynxis lazus. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Patch Set 10: Code-Review+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/5d6c41f3_7b7ce193 PS7, Line 17: premium I also have difficulties to understand what "premium" means in this context. It does refer to the non wild card profile I guess. Patchset: PS10: I do not see any obvious problems with this - looks good to me. File include/osmocom/hlr/hlr.h: https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/1362aa90_790ca974 PS10, Line 67: } pdp_profile; I am sure those two levels exist for a reason. If not, wouldn't it be simpler to have one struct only? Probably this is to match the vty node hierarchy. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 23 May 2023 15:11:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment