Attention is currently required from: jolly, dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 )

Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ......................................................................

Patch Set 1: Code-Review-1

(2 comments)

File include/osmocom/gsm/protocol/gsm_44_068.h:

https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/3c4e6c41_f65af601 PS1, Line 9: (C) 2023 by Andreas Eversberg jolly@eversberg.eu copyright is with sysmocom for code written by employees during work time. Check other files where you have templates like "(C) sysmocom - s.f.m.c. GmbH, Author: ...."

https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/1b482139_0976e0c2 PS1, Line 19: enum gcc_iei { in general we try to avoid clobbering the global namespace with symbols or type names without an osmo_* prefix for new code, see https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards#N...