Attention is currently required from: neels, laforge, daniel, lynxis lazus.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 )

Change subject: Add support for multiple APN profiles for subscriber data ......................................................................

Patch Set 10: Code-Review+1

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/5d6c41f3_7b7ce193 PS7, Line 17: premium

not sure what your critics is

I also have difficulties to understand what "premium" means in this context. It does refer to the non wild card profile I guess.

Patchset:

PS10: I do not see any obvious problems with this - looks good to me.

File include/osmocom/hlr/hlr.h:

https://gerrit.osmocom.org/c/osmo-hlr/+/32512/comment/1362aa90_790ca974 PS10, Line 67: } pdp_profile; I am sure those two levels exist for a reason. If not, wouldn't it be simpler to have one struct only? Probably this is to match the vty node hierarchy.