Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 )
Change subject: gsm_objclass2obj(): Change signature so we can obtain a nack cause in case of error ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/5ba12def_b468da27 PS1, Line 1799: gsm_objclass2obj(enum abis_nm_nack_cause *c, struct gsm_bts *bts, uint8_t obj_class, same here, this should be at the end and be able to pass NULL to it.
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/a9fc8d89_3b6d957a PS1, Line 1804: /* Handle finding TRX number first */ Same here, please don't move this into a new switch.