Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33091 ) Change subject: libosmogsm: Allow auth API caller to specify RES length ...................................................................... Patch Set 3: (2 comments) File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/c9cd087d_ac271639 PS3, Line 224: if (aud->type == OSMO_AUTH_TYPE_UMTS) { I think this should go inside auth_data2auth_data2(), since v2 users are expected to set it always. https://gerrit.osmocom.org/c/libosmocore/+/33091/comment/e4dc52cf_d4044b0a PS3, Line 301: if (aud->type == OSMO_AUTH_TYPE_UMTS) { Add to auth_data2auth_data2, you can drop it from here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33091 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic662843fbe8b5c58e4af39ea630ad5ac13fd6bef Gerrit-Change-Number: 33091 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 May 2023 15:20:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment