Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37011?usp=email ) Change subject: add contrib/saip-tool.py ...................................................................... Patch Set 3: (2 comments) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/37011/comment/431c9bba_bbf3fc4d PS3, Line 37: subparsers = parser.add_subparsers(dest='command', help="The command to perform", required=True) ah nvm, there is already required=True https://gerrit.osmocom.org/c/pysim/+/37011/comment/80e808b0_054e9070 PS3, Line 161: else: : parser.print_help(sys.stderr) : sys.exit(2) this can be removed since opts.command is required -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20 Gerrit-Change-Number: 37011 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 07 Jun 2024 10:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment