Change in docker-playground[master]: debian-bullseye-obs-asan: new container - gerrit-log

4 Aug 2022

Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/28902 )

Change subject: debian-bullseye-obs-asan: new container
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
...
  We can do multi-stage builds
(https://docs.docker.com/develop/develop-images/multistage-build/). […] pespin
wrote:
...
  I'd probably change the osmo-*-master Dockerfiles
to build all dependency libs from master with --enable-asan enabled, I have been doing
that for ages in my local copy of docker-playground.git
 This has the benefit that during development one can for instance, easily set
LIBOSMO_NETIF_BRANCH=myownbranch when testing ie. osmo-stp-master. 
IMHO this is not a good reason to build everything from source in the docker containers.
This approach is suboptimal for getting a short test cycle, one still has to push the
changes to osmocom git servers, then have docker fetch them again and build the program
completely from scratch instead of preserving objects for c files that were not modified.

fixeria wrote:
...
  We can do multi-stage builds
(https://docs.docker.com/develop/develop-images/multistage-build/). Currently most of the
images in docker-playground are built upon debian-bullseye-build. With multi-stage builds
we could build sanitized libosmocore in one image, and then simply use the products of
`make install` for building other libraries like libosmo-abis, and finally for building
sanitized osmo-apps. This approach would eliminate the need for building libosmo-* again
and again for each osmo-*-master image. 
I'm not sure if this would actually make the logic in docker-playground more
complicated.

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28902
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d6e7cc401acadbae9156d3e7f3a6230c2fb198
Gerrit-Change-Number: 28902
Gerrit-PatchSet: 1
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 04 Aug 2022 13:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment