Attention is currently required from: laforge, fixeria, pespin.
1 comment:
Patchset:
We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). […]
pespin wrote:
> I'd probably change the osmo-*-master Dockerfiles to build all dependency libs from master with --enable-asan enabled, I have been doing that for ages in my local copy of docker-playground.git
> This has the benefit that during development one can for instance, easily set LIBOSMO_NETIF_BRANCH=myownbranch when testing ie. osmo-stp-master.
IMHO this is not a good reason to build everything from source in the docker containers. This approach is suboptimal for getting a short test cycle, one still has to push the changes to osmocom git servers, then have docker fetch them again and build the program completely from scratch instead of preserving objects for c files that were not modified.
fixeria wrote:
> We can do multi-stage builds (https://docs.docker.com/develop/develop-images/multistage-build/). Currently most of the images in docker-playground are built upon debian-bullseye-build. With multi-stage builds we could build sanitized libosmocore in one image, and then simply use the products of `make install` for building other libraries like libosmo-abis, and finally for building sanitized osmo-apps. This approach would eliminate the need for building libosmo-* again and again for each osmo-*-master image.
I'm not sure if this would actually make the logic in docker-playground more complicated.
To view, visit change 28902. To unsubscribe, or for help writing mail filters, visit settings.